Skip to content

Lyrics editor improvements - #2256

Merged
Taiko2k merged 47 commits into
Taiko2k:masterfrom
rexendevar:lyrics-editor-improvements
Jul 31, 2026
Merged

Lyrics editor improvements#2256
Taiko2k merged 47 commits into
Taiko2k:masterfrom
rexendevar:lyrics-editor-improvements

Conversation

@rexendevar

@rexendevar rexendevar commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

will resolve #2247

changes:

  • implemented new MultiLineTextBox class
  • TextBox2 now has a headroom parameter to deal with a bug where text would get partially chopped off
  • settings_segmented_bar now has an optional click parameter so it can be used elsewhere
  • new setting which determines whether the save dialog appears
  • new setting which allows static lyrics to optionally not overwrite synced lyrics in metadata
  • new rect_abs draw function
  • new functions to fetch text lines as they will appear after wrapping and to more easily set cursor position based on mouse position
  • fixed bug which caused pctl.playing_time to desync with the actual playing time when pausing with fade enabled
  • fixed bug that allowed del_selected to run while showcase or radio view were open
  • fixed a couple bugs regarding MP3 edge cases
  • fixed bug that caused all of gnome to occasionally crash when tauon did.

in the synced editor:

  • the actively editable column (timestamp while playing, text while paused) is now highlighted visually
  • you can now click in a text box and the focus will stay there
  • column labels when there are few lines or when no actual timestamps exist
  • new rich save dialog
  • new icons instead of text
  • TIME button is more obviously the main button, plus if clicked while grayed out it will start playback
  • removed extraneous save buttons

in the unsynced editor:

  • replaced the text display + file reading system with a multiline text box
  • deleted the edit lyrics button
  • added placeholder text for when the box is empty
  • fixed bug that made the discard button worthless

@Taiko2k Taiko2k left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEEP BOOP IM A BOT... changes requested

Comment thread src/tauon/t_modules/t_main.py Outdated
Comment thread src/tauon/t_modules/t_main.py
Comment thread src/tauon/t_modules/t_main.py
Comment thread src/tauon/t_modules/t_main.py Outdated
Comment thread src/tauon/t_modules/t_main.py
Comment thread src/tauon/t_modules/t_main.py
@rexendevar
rexendevar marked this pull request as ready for review July 27, 2026 23:52
@rexendevar
rexendevar requested a review from Taiko2k July 27, 2026 23:54
@rexendevar
rexendevar dismissed Taiko2k’s stale review July 28, 2026 00:01

Already resolved all the notes

Comment thread src/tauon/t_modules/t_main.py Outdated
Comment thread src/tauon/t_modules/t_main.py Outdated
Comment thread src/tauon/t_modules/t_main.py Outdated
Comment thread src/tauon/t_modules/t_main.py Outdated
@Taiko2k
Taiko2k merged commit 40a296e into Taiko2k:master Jul 31, 2026
8 checks passed
rexendevar added a commit to rexendevar/Tauon that referenced this pull request Jul 31, 2026
* visible indicator for which column is active + new rect_abs function

* fixup! visible indicator for which column is active + new rect_abs function

* optimization

* getting tired. starting 2 work on save box

* exhausting myself

* part 1 of save box done. switching gears

* column labels basics

* minor optimization

* starting to work on better text cursor behavior

* continued improvements

* new edit handling is complete i think

* time button refinements

* replace all humiliation

* icon changes, hacky workaround for text display bug, text edit fix for small window mode

* (mostly) fix time display desync bug

* beginnings of multiline text box

* major progress on multiline text box

* mlt

* no idea what i'm doing

* progress

* text highlighting basics

* multiline text box is alpha ready

* starting to move back towards the editor

* major highlight progress

* yeah

* don't remenbver what i did employers don't read these please

* we are starting our final descent into pr airport

* further refinements

* ctrl text editing with line breax

* abject misery back 2 drawing board. cool new ddt function

* i think i've saved it i think all the text editing and highlighting is actually working again

* regular typing and deleting fixed. found bug where you can't edit the very first character

* possibly actually fixed but i dont believe it

* Sloptimization™

* my brain is leaking out my ears

* cleanup

* one final nut to crack before i'm done

* slop appeasement

* fixed a severe and perplexing buggit add .git add .git add .! i think i'm genuinely ready now

* final cleanup

* styles and types

* tiny spacing change

* chaunge logge

* final
rexendevar added a commit to rexendevar/Tauon that referenced this pull request Aug 1, 2026
* visible indicator for which column is active + new rect_abs function

* fixup! visible indicator for which column is active + new rect_abs function

* optimization

* getting tired. starting 2 work on save box

* exhausting myself

* part 1 of save box done. switching gears

* column labels basics

* minor optimization

* starting to work on better text cursor behavior

* continued improvements

* new edit handling is complete i think

* time button refinements

* replace all humiliation

* icon changes, hacky workaround for text display bug, text edit fix for small window mode

* (mostly) fix time display desync bug

* beginnings of multiline text box

* major progress on multiline text box

* mlt

* no idea what i'm doing

* progress

* text highlighting basics

* multiline text box is alpha ready

* starting to move back towards the editor

* major highlight progress

* yeah

* don't remenbver what i did employers don't read these please

* we are starting our final descent into pr airport

* further refinements

* ctrl text editing with line breax

* abject misery back 2 drawing board. cool new ddt function

* i think i've saved it i think all the text editing and highlighting is actually working again

* regular typing and deleting fixed. found bug where you can't edit the very first character

* possibly actually fixed but i dont believe it

* Sloptimization™

* my brain is leaking out my ears

* cleanup

* one final nut to crack before i'm done

* slop appeasement

* fixed a severe and perplexing buggit add .git add .git add .! i think i'm genuinely ready now

* final cleanup

* styles and types

* tiny spacing change

* chaunge logge

* final
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX improvements to the synced lyrics editor

3 participants